Skip to content

build: migrate to napi-rs v3 #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 24, 2025
Merged

build: migrate to napi-rs v3 #164

merged 4 commits into from
Jul 24, 2025

Conversation

2bndy5
Copy link
Collaborator

@2bndy5 2bndy5 commented Jul 22, 2025

  • bumps all outdated dependencies (pip, npm, cargo).
  • upgrade to yarn v4.9.2
  • switch from eslint to oxlint
  • add spellcheck as pre-commit hook
  • removes the bindings/node/npm folder as this is now generated in CI
  • adds a check to ensure the PR title uses conventional commit standard (enforced and configured via committed tool)
  • fixes deprecated API about probing system SSL certificates (when openSSL is vendored)
  • adds commit filters specific to conventional commit messages when generating the CHANGELOG

@2bndy5 2bndy5 added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code javascript Pull requests that update Javascript code python Pull requests that update Python code labels Jul 22, 2025
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.90%. Comparing base (ada1fbc) to head (137c097).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
- Coverage   97.53%   96.90%   -0.64%     
==========================================
  Files          14       14              
  Lines        3406     3132     -274     
==========================================
- Hits         3322     3035     -287     
- Misses         84       97      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@2bndy5 2bndy5 force-pushed the napi-rs-v3 branch 3 times, most recently from c84741a to 6c856c2 Compare July 22, 2025 19:17
Copy link

codspeed-hq bot commented Jul 22, 2025

CodSpeed Performance Report

Merging #164 will not alter performance

Comparing napi-rs-v3 (137c097) with main (ada1fbc)1

🎉 Hooray! codspeed-rust just leveled up to 3.0.4!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 1 untouched benchmarks

Footnotes

  1. No successful run was found on main (e69ce36) during the generation of this report, so ada1fbc was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@2bndy5 2bndy5 force-pushed the napi-rs-v3 branch 3 times, most recently from 94f2cea to e133d4e Compare July 23, 2025 04:20
- bumps all outdated dependencies (pip, npm, cargo).
- upgrade to yarn v4.9.2
- switch from eslint to [oxlint]
- add spellcheck as pre-commit hook
- removes the bindings/node/npm folder as this is now generated in CI
- adds a check to ensure the PR title uses conventional commit standard (enforced and configured via [committed] tool)
- fixes deprecated API about probing system SSL certificates (when openSSL is vendored)
- adds commit filters specific to conventional commit messages when generating the CHANGELOG

[oxlint]: https://oxc.rs/docs/guide/usage/linter.html
[committed]: https://github.com/crate-ci/committed
@2bndy5 2bndy5 marked this pull request as ready for review July 23, 2025 05:00
@2bndy5 2bndy5 force-pushed the napi-rs-v3 branch 2 times, most recently from d29d3ef to dfdf539 Compare July 23, 2025 20:22
@2bndy5 2bndy5 merged commit 7c2b5ed into main Jul 24, 2025
76 checks passed
@2bndy5 2bndy5 deleted the napi-rs-v3 branch July 24, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code python Pull requests that update Python code rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant