Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
ac779f5 to
9fe97a2
Compare
LLGo baseline benchmarks
Program measurements
Core language and compiler benchmarks
Compared only with the latest matching platform in the main series. |
|
Benchmark context: the large Linux whole-file deltas are the expected debugger-owned DWARF cost of xgo-dev#2164 Go-compatible defaults (native = embedded), not an equivalent loadable-footprint increase. Against the latest main baseline, Linux text/data are cprintf 410/13,813 vs 410/12,949 bytes; println 21,929/30,789 vs 21,337/29,283 bytes; and fmtprintf 768,473/997,255 vs 759,177/982,167 bytes. The proposal artifact-role gate separately measures debug and deployment outputs, and the Targets lane verifies that host DWARF leaves flashed bytes identical. Production stripping remains explicit through -debug-artifact=none or -w; full-DWARF build-time cost remains tracked. |
|
Compatibility shard follow-up:
This is therefore treated as a timing flake. No debugger acceptance assertion or runtime behavior was weakened. |
|
Superseded by xgo-dev#2142 (native fault/inline acceptance), current main (existing Go/C boundary and final Wasm DWARF foundations), xgo-dev#2269 (12 final Wasm artifact/execution cases), and xgo-dev#2713 (real browser sessions). The supported patched Binaryen baseline replaces the historical temporary pin. Closing this historical fork PR only; its branch remains available. The replacement contributions remain open for review and CI. Consolidation: xgo-dev#2164. |
Continues xgo-dev#2164 on top of #139.
This change closes native fault/boundary acceptance gaps and makes clean final WebAssembly DWARF a hard gate without changing runtime or scheduler behavior:
llvm-dwarfdump --verify;llgo.yml/wasi-debug.yml, and the browser fixture in Chrome 151.Validation:
python3 check.py wasm-optin the pinned Binaryen treellvm-dwarfdump --verifyreportsNo errors..debug.wasmsidecar:No errors..debug.wasmsidecar:No errors.go test -timeout 10m ./internal/debugabi ./internal/wasmdebug ./internal/browserdebug ./cmd/internal/browser ./cmd/internal/debuggo test ./internal/build: pass in 290.468s after the final-gate auditNATIVE_DEBUG_ACCEPTANCE_OKNATIVE_DEBUG_ACCEPTANCE_OKThe Binaryen pin can return to the supported Emscripten release after the upstream repair lands and is released.