This repository was archived by the owner on Jul 22, 2022. It is now read-only.
Fixed Missing Styling on Explore and Sponsor Dashboard Pages#110
Open
zfett wants to merge 2 commits intocquanu:masterfrom
zfett:master
Open
Fixed Missing Styling on Explore and Sponsor Dashboard Pages#110zfett wants to merge 2 commits intocquanu:masterfrom zfett:master
zfett wants to merge 2 commits intocquanu:masterfrom
zfett:master
Conversation
- Added .selected and :hover CSS for .subnav-link on Explore page - Added CSS styling for sidebar menu navigation on Sponsors Dashboard.
Contributor
|
Hi, Sorry for getting to this so late. I've had a bad illness. Why did you close the PR? |
Author
|
Sorry for that. I thought I PR’d on a dead topic so I closed it. I’ll reopen it for review! |
snowe2010
suggested changes
Jan 13, 2020
| @@ -9,7 +9,6 @@ | |||
| @-moz-document domain("github.com") { | |||
Contributor
There was a problem hiding this comment.
Could you pull the formatting changes out into a second PR? Also it seems your formatter is removing newlines where I put them so if you could leave those in place that would be good.
You also just copied and pasted the .user.css into the .css. Just don't worry about the .css file, I'm going to deprecate that soon.
Could you also provide some screenshots so I can verify the changes on my end too? Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the issue:
No styling for the top navigation links on the Explore page and no styling for the sidebar navigation menu on the Sponsors dashboard.
What's fixed: