Conversation
* Refresh Craft Cloud package for Craft 6 * Remove test app key fixture * Disable Craft plugin installer in CI * Add Husky pre-commit lint hook
# Conflicts: # composer.lock
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 23fc6fe134
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| $process = Process::fromShellCommandline($shellCommand, null, $environment, null, self::PROCESS_TIMEOUT_SECONDS); | ||
|
|
||
| $process->run(function($type, $buffer): void { | ||
| $shellCommand = '"${:PHP_BINARY}" /var/task/craft ' . $command; |
There was a problem hiding this comment.
The shell command now appends $command directly to fromShellCommandline(...), so metacharacters in the event/SQS payload (e.g. ;, &&, backticks) are interpreted by the shell instead of being passed as craft arguments. This is a regression from the previous escapeshellcmd(...) path and allows execution of unintended commands whenever an attacker or malformed upstream payload can influence command.
Useful? React with 👍 / 👎.
| } | ||
| } | ||
|
|
||
| return null; |
There was a problem hiding this comment.
When SRV lookup fails or CRAFT_CLOUD_CACHE_SRV is unset, resolveRedisUrl() now always returns null, which silently disables Redis cache configuration and forces failover to database/array only. Previous behavior supported a legacy CRAFT_CLOUD_REDIS_URL fallback, so environments still on that variable will regress to slower non-Redis caching after this change.
Useful? React with 👍 / 👎.
1 participant
Summary
stderron Lambdabref.logging.*directionTesting
BrefServiceProviderTestcovers the Lambda logging behavior and the emergency channel override