[3.x] Use native transforms for action requests#160
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aabe5b8782
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| try { | ||
| Assets::downloadFile($asset->getVolume(), $asset->getPath(), $tempPath); | ||
| $this->normalizeUploadedImageOrientation($tempPath); |
There was a problem hiding this comment.
On sites that set rotateImagesOnUploadByExifData to false, this still rotates every EXIF-oriented JPEG/TIFF because the new normalization runs unconditionally before Image::cleanImageByPath(). Craft’s image cleanup already gates EXIF rotation on that general config, so Cloud uploads now ignore a setting that native uploads honor; CP users who disabled EXIF rotation will see direct Cloud uploads saved with different pixels/dimensions than expected.
Useful? React with 👍 / 👎.
timkelty
force-pushed
the
timkelty/fix-cloud-exif-orientation
branch
from
aabe5b8 to
f29bc20
Compare
timkelty
force-pushed
the
timkelty/fix-cloud-exif-orientation
branch
from
f29bc20 to
b513507
Compare
timkelty
changed the title
1 participant
Description
Skip Cloud’s asset CDN transform override during Craft action requests so handlers like the image editor use Craft’s native transform pipeline.
This keeps image-editor preview URLs and server-side save/crop behavior in the same coordinate space, matching native Craft behavior for unsanitized CP uploads.