Refactors the legacy JS a bit#19003
Draft
brianjhanson wants to merge 14 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A constant work in progress.
#18997 surfaced a problem with our previous approach. On inertia pages we don't currently load the
CpAsset, mostly because that comes with a lot of stuff, a good chunk of which we don't need or want in the inertia context.This updates our approach to include a shim for inertia pages that will bridge the gap between what legacy pages expect and what inertia pages provide.
There's a fair amount of gymnastics in here that the robots helped me out with. I imagine over time we'll see if those things are necessary or not.
The styles are still rough for legacy fields, but they should at least be functional with these changes.
Fixes #18997