Skip to content

Relocate ValidationRulesResolving#19040

Merged
brandonkelly merged 5 commits into
6.xfrom
bugfix/validation-event-types
Jun 5, 2026
Merged

Relocate ValidationRulesResolving#19040
brandonkelly merged 5 commits into
6.xfrom
bugfix/validation-event-types

Conversation

@AugustMiller
Copy link
Copy Markdown
Contributor

100% breaking changes! 😈

  • The ValidationRulesResolving is no longer emitted for only Elements, so I've relocated it into the Validation namespace.
  • It also had some compatibility issues when Rulesets were used in place of FormRequests… specifically that ValidationRulesResolving::$component (now $subject) wasn't permissive enough for Request objects.
  • The Ruleset responsible for $rules on the event is now included, as well.

CHANGELOG.md contains specific descriptions, and the event class docblock has been updated with an example of expected usage.

@AugustMiller
Copy link
Copy Markdown
Contributor Author

Testing locally, I got a bizarre failure with Tests\Unit\Support\DiffTest 🙃

@brandonkelly brandonkelly merged commit 8d4b826 into 6.x Jun 5, 2026
9 checks passed
@brandonkelly brandonkelly deleted the bugfix/validation-event-types branch June 5, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants