fix(desktop): stabilize Linux Wayland transparency and overlays - #670
Merged
Conversation
Rebase of #614 onto main, with the three main.zig conflicts resolved in favor of what landed after that branch was written: - gpu_alpha_mode stays premultiplied on every platform. #662 changed it from opaque on purpose to kill the visible rectangle behind the transparent window, and locked it with a test. The linux software backend from this branch is preserved. - syncBubbleWindow keeps the mutable model from #667, so the flip is decided where it is consumed, with the linux popup early-return on top. - the non-linux bubble descriptor keeps bubbleWantY and fullscreen_overlay from #667 and #656; this branch still carried the pre-#667 geometry, which would have reverted both. Original work by ThermalEng in #614. Opened as a new branch because the source branch is the fork's main. Co-authored-by: ThermalEng <38897886+ThermalEng@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
The transparency test asserted an opaque settings window on every platform. That holds on AppKit and Win32, where the pet window owns its transparency and settings paints its own page background. Linux presents every surface through one alpha-zero GTK clear, so settings is transparent there too and the assertion failed on that runner only. Co-authored-by: ThermalEng <38897886+ThermalEng@users.noreply.github.com>
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #614 onto current main. All the code is ThermalEng's work; this branch exists because #614 is opened from its fork's
main, so rebasing it in place would rewrite that branch.Supersedes #614. Credit stays with ThermalEng via
Co-authored-by.Conflicts resolved
Three in
main.zig, each kept whatever landed after that branch was written:gpu_alpha_modestayspremultipliedon every platform. [codex] keep activity bubbles anchored across displays #662 changed it fromopaquedeliberately to kill the visible rectangle behind the transparent window, and locked it with a test. The Linuxsoftwarebackend from this branch is preserved.syncBubbleWindowkeeps the mutable model from [codex] keep activity bubbles clear of pet #667, so the flip is decided where it is consumed, with the Linux popup early-return on top.bubbleWantYandfullscreen_overlayfrom [codex] keep activity bubbles clear of pet #667 and feat(desktop): focus originating terminal and support fullscreen overlays #656. This branch still carried the pre-[codex] keep activity bubbles clear of pet #667 geometry, which would have reverted both.Testing
native test: 108/108 passed against the pinned SDK (c0b10d02).SDK pins agree: both workflows still on c0b10d02.src/, so nothing from feat(gallery): surface sprite atlas versions #658 is reverted.