Deprecate redundant section configuration#66
Open
jamie-s-white wants to merge 1 commit into
Open
Conversation
This was referenced Jul 4, 2025
Contributor
|
Hey @jamie-s-white sorry back in the office after a (long) summer break - thank you for these amazing PR's. Seeing you're using the typesense config. Would you be open to connect. As I'm in the works of rebuilding it from the ground up. Might be nice to have a discussion about it with someone actually using it intensively. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completely removes the section configuration parameter from this plugin, and instead runs all corresponding code through the criteria defined in the configuration. This has two main benefits:
Because section is no longer used in any way, I have also added deprecation warnings if it stays in the configuration file. For example: