Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template): Upgrade unrendered variable to a warning #863

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

epage
Copy link
Collaborator

@epage epage commented Feb 5, 2025

In #604, we held off on this being a warning.
Seems reasonable at this point to give it a try.

Fixes #862

In crate-ci#604, we held off on this being a warning.
Seems reasonable at this point to give it a try.

Fixes crate-ci#862
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13163238570

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 8.831%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ops/replace.rs 0 1 0.0%
Totals Coverage Status
Change from base Build 13077492474: 0.0%
Covered Lines: 222
Relevant Lines: 2514

💛 - Coveralls

@epage epage merged commit 79a287a into crate-ci:master Feb 5, 2025
14 checks passed
@epage epage deleted the warn branch February 5, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should warn or fail when replacements aren't applied
2 participants