Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Poppins font with Montserrat #460

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Conversation

msbt
Copy link
Collaborator

@msbt msbt commented Feb 15, 2024

About

As mentioned in chat, the CI font for headlines changed a while ago, this will fix it

Preview

https://crate-docs-theme--460.org.readthedocs.build/en/460/

@msbt msbt requested review from amotl and matkuliak February 15, 2024 15:01
Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I like that font much better. Can we have a just-a-bit-more-condensed variant, when possible?

@msbt
Copy link
Collaborator Author

msbt commented Feb 20, 2024

@amotl when you say condensed, do you mean like adding a letter-spacing: -1px;?

@amotl
Copy link
Member

amotl commented Feb 20, 2024

When the font does not offer a condensed variant, we can only use letter spacing, right. However, I don't know if that will have a pleasant appearance.

@msbt
Copy link
Collaborator Author

msbt commented Feb 22, 2024

@amotl those are available: https://gwfh.mranftl.com/fonts/montserrat?subsets=latin

This is how it looks now:
image

This is how it would look like with -1px:
image

Feel free to poke around with the element inspector if 1px is not what you imagined :)

@msbt msbt merged commit 327b7ce into main Feb 22, 2024
8 checks passed
@msbt msbt deleted the matthias/poppins-vs-montserrat branch February 22, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants