Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix the missing index.html in canonical URLs #482

Closed
wants to merge 1 commit into from

Conversation

msbt
Copy link
Collaborator

@msbt msbt commented Apr 25, 2024

Summary of the changes / Why this is an improvement

This should add the missing index.html for canonical URLs (original issue: https://github.com/crate/tech-writing/issues/417#issuecomment-2066746951). Can we do a demo to test thoroughly before going live? Tested locally, but not sure what happens when RTD is trying to add their own code, could be either ignored or this piece overwritten.

Code is borrowed from https://github.com/readthedocs/readthedocs-sphinx-ext/blob/614109c6ad11eaacbcde1040b908967c80b81eba/readthedocs_ext/_templates/readthedocs-insert.html.tmpl#L4-L19

@msbt msbt requested a review from amotl April 25, 2024 09:51
@msbt
Copy link
Collaborator Author

msbt commented Apr 25, 2024

@amotl any idea what's happening there? ;)

@amotl
Copy link
Member

amotl commented May 6, 2024

Superseded by GH-488.

@amotl amotl closed this May 6, 2024
@amotl amotl deleted the matthias/canonical-index-fix branch May 6, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants