Skip to content

Migrate SQL Editor history from single-cluster to multi-cluster #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

alexdametto
Copy link
Collaborator

@alexdametto alexdametto commented May 30, 2025

Summary of changes

Idea behind this PR:

  • having a unique history of 100 queries
  • the new history array will contains object like { clusterId, query }
  • migrating the old "string-only" history into the new structure

I have not add any test since the "migration" code will probably be removed in a couple of months.

⚠️ I will update this PR do to the release next week, to avoid any conflicts.

Checklist

  • Link to issue this PR refers to: https://github.com/crate/cloud/issues/2607
  • Relevant changes are reflected in CHANGES.md.
  • Added or changed code is covered by tests.
  • Required Grand Central APIs are already merged.

@alexdametto alexdametto marked this pull request as ready for review May 30, 2025 14:45
@alexdametto alexdametto requested a review from joncombe as a code owner May 30, 2025 14:45
Copy link
Collaborator

@joncombe joncombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, approved, but can we have a quick chat about the migration when you are back, pls? I am slightly confused how this only runs once.

@joncombe
Copy link
Collaborator

joncombe commented Jun 3, 2025

Ignore my question about the migration thing. I see how this works now.

@alexdametto alexdametto merged commit 3eb1ece into master Jun 3, 2025
1 check passed
@alexdametto alexdametto deleted the ad/storage-quota branch June 3, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants