-
-
Notifications
You must be signed in to change notification settings - Fork 336
Rename static-php-cli to StaticPHP #976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
static-php instead of StaticPHP? Not sure, but StaticPHP looks unexpected. |
|
StaticPHP appears to be more SEO-friendly. Using it as the brand's display name (while the internal names and IDs are still static-php and static-php-cli) is, I guess, a relatively safe solution. |
|
I think SEO friendly is not a thing we need to care about. My concern is that we already have static-php.dev, my packages link to it and people already know the project as static-php(-cli). |
|
Haha, actually I personally prefer calling it Of course, given that our project is already well-known, I think keeping |
henderkes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FrankenPHP, CakePHP, and NativePHP
That's a fair point. Is staticphp.dev for the grabs?
Now I've owned |
When we're switching to |
What does this PR do?
Prepare for future brand promotion :/
I have reservations about renaming and moving the repository, as GitHub will automatically redirect to the new repository, so it may not be difficult. But I think it's not too late to do it after version 3.0.
Checklist before merging
*.phpor*.json, run them locally to ensure your changes are valid:composer cs-fixcomposer analysecomposer testbin/spc dev:sort-configsrc/globals/test-extensions.php.extension testortest extensionsto trigger full test suite.