test: microshift: Don't force network-mode to 'user' #3804
Conversation
|
/hold |
|
@jsliacan Can you try that and see if that works as expected. |
cfergeau
force-pushed
the
e2e-microshift
branch
from
9bae8e5 to
12c5074
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
With the switch to user-mode networking everywhere, this probably can go in now. |
|
Now by default network mode is user so we dont' force it anymore. /close |
|
@praveenkumar: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This needs rebase, it’s now less important as it’s just a cleanup now that usermode networking is default, but I’m not sure there is nothing to do anymore |
We want our testing to be as close as possible to what end-users will experience. Changing `network-mode` is a significant difference from the default. `user` is now the default so we don’t need to explicitly set it. Signed-off-by: Christophe Fergeau <[email protected]>
…latform" This reverts commit 557ec94. We no longer set network-mode as part of the tests, so this code is not needed. Signed-off-by: Christophe Fergeau <[email protected]>
|
The updated PR removes no longer needed code. |
|
@cfergeau: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| // Since network-mode is only supported on Linux, we skip this property test for non-linux platforms | ||
| if property == "network-mode" && runtime.GOOS != "linux" { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Shouldn't this still true? On linux network-mode is still have option for system and user (being default)?
Filing this now so that we don't forget it when we have bundles with crc-org/snc#797. This will be put on hold until this happens.
We want our testing to be as close as possible to what end-users will
experience. Changing
network-modeis a significant difference from thedefault. With crc-org/snc#797 fixed, we no longer
need to force it to
user.