ARIA attribute added to website for accessibility by SisiVero · Pull Request #336 · creativecommons/cc-resource-archive

SisiVero · 2024-10-11T22:23:46Z

Fixes

Fixes [Feature] Introduce ARIA attributes to the website for accessibility #319 by @Murdock9803

Description

This PR addresses the issue of adding ARIA to the website to enhance accessibility.

Tests

ARIA were added to the necessary files accordingly.

Checklist

My pull request has a descriptive title (not a vague title like Update index.md).
My pull request targets the default branch of the repository (main or master).
My commit messages follow best practices.
My code follows the established code style of the repository.
I added or updated tests for the changes I made (if applicable).
I added or updated documentation (if applicable).
I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Murdock9803 · 2024-10-12T04:24:18Z

Looks good to me,
@possumbilities Is this sufficient in comparison to what we were expecting from ARIA addition ?

SisiVero · 2024-10-12T12:14:32Z

Thank you @Murdock9803

possumbilities · 2024-10-14T15:38:51Z

+    <h1><a class="identity-logo product" href="/" aria-label="Resource Archive">Resource Archive</a></h1>

-    <nav class="ancilliary-menu">
+    <nav class="ancilliary-menu" role="navigation" aria-label="Main menu">


This label is incorrect, it should bw Ancillary Menu

there is a current open issue on this, pr has been created to address this issue from vocabulary repo.

possumbilities · 2024-10-14T15:41:22Z

Hi @SisiVero There's a lot of work here and after starting to review it I believe there's a distinction worth putting here. Work here would need to be on items held within the content area of the cc-resource-archive pages. The global header and global footer, if they could do with improvements related to ARIA, that is work that should be documented as an Issue on the main Vocabulary repository, and then done via PRs there.

We don't want the header/footer forking from upstream here.

SisiVero · 2024-10-14T16:52:27Z

Okay, @possumbilities , I think there is an open issue on that currently, I'll verify.
If there isn't, I can go ahead and open one, yes?
I'll ho ahead and fix the ones specifically for this repo.

possumbilities · 2024-10-14T17:15:43Z

@SisiVero If you believe its not covered there, please feel free to.

…e pages.

SisiVero · 2024-10-15T07:47:40Z

Hi @possumbilities , i've removed the aria attributes from the footer and header. do review and get back to me, thank you.

SisiVero · 2024-11-20T15:46:56Z

Hi @possumbilities , after going through the resources shared by @TimidRobot , I realized that there were lots of duplication of texts.
I have made some changes to the files and it seems only one particular element in a file needed an aria-label.
This element might still do without it.
Could you review these changes when you can? We can come to a conclusion on whether to leave it or leave it out entirely.
Thank you.

possumbilities · 2024-12-09T18:29:30Z

          >
            <article>
-              <img class="thumbnail" src="{{page.image-thumb}}" alt="{% if
+              <img


This doesn't seem to be related to ARIA?

possumbilities · 2024-12-09T18:29:41Z

          >
            <article>
-              <img class="thumbnail" src="{{page.image-thumb}}" alt="{% if
+              <img


This doesn't seem to be related to ARIA?

possumbilities · 2024-12-09T18:29:51Z

          rel="license"
          href="http://creativecommons.org/licenses/{{ page.license | remove: 'CC ' | downcase | replace: ' ', '/' }}/"
-        >
+          >


Seems unrelated to PR, please remove.

possumbilities · 2024-12-09T18:30:01Z

            alt="Creative Commons License"
            src="http://i.creativecommons.org/l/{{ page.license | remove: 'CC ' | downcase | replace: ' ', '/' }}/88x31.png"
-          />
+            />


Sees unrelated to PR, please remove.

ARIA attribute added to website for accessibility

fb1680b

SisiVero requested a review from a team as a code owner October 11, 2024 22:23

SisiVero requested review from Shafiya-Heena and TimidRobot and removed request for a team October 11, 2024 22:23

Murdock9803 requested review from Murdock9803 and possumbilities and removed request for Shafiya-Heena and TimidRobot October 12, 2024 04:17

possumbilities reviewed Oct 14, 2024

View reviewed changes

Comment thread docs/_includes/footer.html Outdated

possumbilities reviewed Oct 14, 2024

View reviewed changes

Comment thread docs/_includes/footer.html Outdated

possumbilities reviewed Oct 14, 2024

View reviewed changes

Comment thread docs/_includes/header.html Outdated

possumbilities reviewed Oct 14, 2024

View reviewed changes

SisiVero added 2 commits October 15, 2024 00:41

aria attributes set within the content area of the cc-resource-archiv…

1770329

…e pages.

aria and added space removed from footer and header

bc2156a

SisiVero requested a review from possumbilities October 18, 2024 07:56

SisiVero added 2 commits November 20, 2024 05:15

aria features that duplicate texts have been removed.

be86b46

unwanted changes removed in listing.html

d3aa5a3

possumbilities reviewed Dec 9, 2024

View reviewed changes

Uh oh!

Conversation

SisiVero commented Oct 11, 2024

Fixes

Description

Tests

Checklist

Developer Certificate of Origin

Uh oh!

Murdock9803 commented Oct 12, 2024

Uh oh!

SisiVero commented Oct 12, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

possumbilities Oct 14, 2024

Choose a reason for hiding this comment

Uh oh!

SisiVero Oct 15, 2024

Choose a reason for hiding this comment

Uh oh!

possumbilities commented Oct 14, 2024

Uh oh!

SisiVero commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

possumbilities commented Oct 14, 2024

Uh oh!

SisiVero commented Oct 15, 2024

Uh oh!

SisiVero commented Nov 20, 2024

Uh oh!

possumbilities Dec 9, 2024

Choose a reason for hiding this comment

Uh oh!

possumbilities Dec 9, 2024

Choose a reason for hiding this comment

Uh oh!

possumbilities Dec 9, 2024

Choose a reason for hiding this comment

Uh oh!

possumbilities Dec 9, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SisiVero commented Oct 14, 2024 •

edited

Loading