-
Notifications
You must be signed in to change notification settings - Fork 682
Add solana token rank #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add solana token rank #445
Conversation
please review |
Sorry, don't add screenshot to project. Upload the screenshot here, in PR conversation. Additionally, we want to know if the skill is working correctly within IntentKit, rather than whether the skill itself can execute. You can start IntentKit and debug the skill according to the documentation below. https://github.com/crestalnetwork/intentkit/blob/main/DEVELOPMENT.md |
To expedite the review process, please join https://discord.com/invite/crestal, open a support ticket to apply for an intentkit dev role. We have a discussion channel there for you to join up with the rest of the developers. |
async def _arun(self, wallet_address: str, token_mint: str, **kwargs) -> str: | ||
try: | ||
base_url = "https://api.helius.xyz/v0/tokens/holding" | ||
api_key = "YOUR_HELIUS_API_KEY" # Replace with env or system config in production |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not the right way to add the api key, please check how other skills get the api key from config, you're need to add it in the .env file, thanks!
amount = token_data.get("amount") | ||
|
||
# Simulate a rank and top holder — in real code you'd use on-chain index or API | ||
fake_rank = 1234 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this simulation needs to be removed, as it should work using the api only!
"$schema": "http://json-schema.org/draft-07/schema#", | ||
"type": "object", | ||
"title": "Solana Token Rank Skill", | ||
"description": "Configuration schema for Solana Token Rank skill", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add an image in the solana_token_rank folder, and add the image path here as it is being done in the other skills, thanks!
Hi @Sharkonland this PR can be reviewed and merged, as soon as these above mentioned issues are resolved. thanks! |
Description
This PR adds a new skill category
solana_token_rank
. It allows agents to check a wallet's rank, amount held, and top holder information for a given token on the Solana network using Helius API and DexScreener.Type of Change
Checklist
Screenshots
Below are screenshots of successful testing of the skill:
#issue number