Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RLink Forwarding Issue #2090

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oberstet
Copy link
Contributor

@oberstet oberstet commented Aug 23, 2023

Fix for #2079

  • Corrected param name
  • Added variable for repetitively accessed dictionary value
  • extended if statement to also check if "sub" is not None to see if the subscription has actually been made.
  • Added on_remote_leave to empty dictionary of forwarded subscriptions
  • extended if statement to also check if "reg" is not None to see if the registration has actually been made.
  • Made "create forwarding registration" log debug level to match the subscription one. This is expected functionality and there can be large amounts of registrations which would cause log spam.

- Added variable for repetitively accessed dictionary value
- extended if statement to also check if "sub" is not None to see if the subscription has actually been made.
- Added on_remote_leave to empty dictionary of forwarded subscriptions
- extended if statement to also check if "reg" is not None to see if the registration has actually been made.
- Made "create forwarding registration" log debug level to match the subscription one. This is expected functionality and there can be large amounts of registrations which would cause log spam.
@oberstet oberstet changed the title Fix for #2079 RLink Forwarding Issue Aug 23, 2023
@oberstet
Copy link
Contributor Author

unfortunately, the CI is broken (well, not running at all) because of #2092

@DZabavchik
Copy link
Contributor

I'm preparing a PR with multiple fixes for RLinks.
Offtopic, is there a way to sponsor or host CI for the project?

Copy link
Contributor

@DZabavchik DZabavchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contais errors (i.e. calling unregister on a subscription).

@oberstet
Copy link
Contributor Author

Offtopic, is there a way to sponsor or host CI for the project?

first of all, that would be highly welcome of course!

to be precise about the current situation: a number of companies are using Crossbar.io in production, and do have an interest in this stuff working or improving.

"CI" is one area, and continuing that, and also improving CI and specifically unit and functional test coverage, as well as auto-building of binary releases come to my mind.

of course this requires some technical resources, but this is only a tiny fraction of the overall costs. it's pretty much negligible compared to engineering costs, and now the old company is gone, we might also go back to GitHub hosted CI (runners) again.

but from my experience, there are substantial engineering / developer costs. It is just an incredible time consuming (and nerve wrecking;) activity.

personally, I cannot rationally justify sinking even more time for zero money into this. and I am saying this even though I've invested countless hours and heart into this stuff over many year, I am still convinced it is quite a good technology worth keeping alive, and there is still stuff to complete. but it's unsustainable in the long run personally.

having said all that, could you imagine supporting via GitHub Sponsors?

if so (in principle), I could figure out the details, setup GH sponsors etc ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants