fix fallback remediation

Author: mobula9

src/ApiCache.php

@@ -280,9 +280,9 @@ private function saveRemediationsForIp(array $decisions, string $ip): string
         if (\count($decisions)) {
             foreach ($decisions as $decision) {
                 if (!\in_array($decision['type'], Constants::ORDERED_REMEDIATIONS)) {
-                    $highestRemediationLevel = Constants::ORDERED_REMEDIATIONS[0];
-                    $this->logger->warning('', ['type' => 'UNKNOWN_REMEDIATION', 'remediation' => $decision['type']]);
-                    $decision['type'] = $highestRemediationLevel;
+                    $fallback = $this->config['fallback_remediation'];
+                    $this->logger->warning('', ['type' => 'UNKNOWN_REMEDIATION', 'unknown' => $decision['type'], 'fallback' => $fallback]);
+                    $decision['type'] = $fallback;
                 }
                 $remediation = $this->formatRemediationFromDecision($decision);
                 $remediationResult = $this->addRemediationToCacheItem($ip, $remediation[0], $remediation[1], $remediation[2]);

src/Bouncer.php

@@ -89,19 +89,6 @@ private function capRemediationLevel(string $remediation): string
         return $remediation;
     }
 
-    /**
-     * If the CrowdSec remediation is not handled by this library,
-     * replace it with the value of the configuration "fallback_remediation".
-     */
-    private function handleUnknownRemediation(string $remediation): string
-    {
-        if (!\in_array($remediation, Constants::ORDERED_REMEDIATIONS)) {
-            return $this->config['fallback_remediation'];
-        }
-
-        return $remediation;
-    }
-
     /**
      * Get the remediation for the specified IP. This method use the cache layer.
      * In live mode, when no remediation was found in cache,
@@ -116,7 +103,6 @@ public function getRemediationForIp(string $ip): string
             throw new BouncerException("IP $ip should looks like x.x.x.x, with x in 0-255. Ex: 1.2.3.4");
         }
         $remediation = $this->apiCache->get(long2ip($intIp));
-        $remediation = $this->handleUnknownRemediation($remediation);
 
         return $this->capRemediationLevel($remediation);
     }