Open
Conversation
👷 Deploy request for chronofactorem pending review.Visit the deploys page to approve it
|
pnicto
approved these changes
Jun 18, 2023
Comment on lines
+9
to
+18
| # Deploy stage | ||
| FROM node:17-bullseye-slim | ||
| WORKDIR /usr/src/app | ||
|
|
||
| COPY --chown=node:node . . | ||
| RUN rm -rf client | ||
| RUN mkdir -p client/build | ||
| COPY --from=chrono-build-stage --chown=node:node /usr/src/app/build /usr/src/app/client/build | ||
|
|
||
| RUN apt-get update && apt-get install -y --no-install-recommends dumb-init && apt-get clean && rm -rf /var/lib/apt/lists/* |
Member
There was a problem hiding this comment.
I think explicitly setting NODE_ENV again in the deploy stage would be a good idea. Everything else looks good.
Member
Author
There was a problem hiding this comment.
I'll do this, and I'll be optimizing it a little more (docker cache works really well with pnpm)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the docker build multi-stage
I'm new to this, so I need a review to see if this is the right way to do it.