Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Fix workflow inputs #47

Merged
merged 4 commits into from
Jul 4, 2023
Merged

[CI] Fix workflow inputs #47

merged 4 commits into from
Jul 4, 2023

Conversation

straight-shoota
Copy link
Member

Fixup for #45

Adds the ability to specify the shards version.
Defaults all versions to nightly.
Skips some tests that are failing on Windows.
Patches ameba for 1.9 compatibility.

@straight-shoota straight-shoota added the bug Something isn't working label Jul 2, 2023
@straight-shoota straight-shoota self-assigned this Jul 2, 2023
@beta-ziliani
Copy link
Member

Specs are failing in Ubuntu for jeromegn/kilt. Why did you need to lower the macOS version?

@straight-shoota
Copy link
Member Author

straight-shoota commented Jul 3, 2023 •
edited
Loading

The pull_request job seems to be outdated? It's running on an old commit. I don't think re-running helps to fix that 🤷
The equivalent push job succeeds, to I think it's fine.

macos-12 is because macos-13 is still a beta version and has some issues (ref crystal-lang/install-crystal#26 (comment)).

(Not that I have anything against betas! 🤗)

beta-ziliani
beta-ziliani reviewed Jul 3, 2023
View reviewed changes
test/libraries.bats
@@ -99,6 +99,7 @@ function setup() {
if [[ "$(crystal env CRYSTAL_VERSION)" =~ ^0\.|^1\.[0-8]\. ]]; then
skiponwindows "Compiler bug in Crystal < 1.9"
fi
skiponwindows "Specs are failing"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of having the three lines above, if it's going to be skipped anyway?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's different reasons for skipping. This documents that it's not expected to build with Crystal 1.8 and below. But after that it's (probably) up to the shard wether it works or not.

beta-ziliani
beta-ziliani approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@beta-ziliani beta-ziliani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Answering myself: I assume the idea is that once we get the specs running OK in Windows, it still makes sense to filter them out with the version of Crystal being < 1.9

@straight-shoota straight-shoota merged commit 66bfb26 into master Jul 4, 2023
@straight-shoota straight-shoota deleted the fix/workflow-inputs branch July 4, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beta-ziliani beta-ziliani beta-ziliani approved these changes

Assignees

@straight-shoota straight-shoota

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@straight-shoota @beta-ziliani