Fix escaping sequence names in health check#94
Closed
gsoltis wants to merge 1 commit intocrystaldba:mainfrom
Closed
Fix escaping sequence names in health check#94gsoltis wants to merge 1 commit intocrystaldba:mainfrom
gsoltis wants to merge 1 commit intocrystaldba:mainfrom
Conversation
surajmandalcell
referenced
this pull request
in surajmandalcell/pgsql-mcp
Dec 14, 2025
This commit addresses the following issues: - #118: Add percentile_cont, percentile_disc, mode to ALLOWED_FUNCTIONS - #111: Fix PostgreSQL ≤12 compatibility for stddev_exec_time column - #110: Fix Docker entrypoint (add exec) and create app user in Dockerfile - #109 & #94: Fix double quote parsing and sequence name escaping - #99: Add configurable query timeout via QUERY_TIMEOUT env var or --query-timeout - #95: Redirect logging to stderr to avoid interfering with stdio MCP transport - #93: Update broken README links to archived MCP servers repo - #100 & #74: Add uvx and WSL instructions to README - #71: Add table/column comments to metadata tools (list_objects, get_object_details) Changes: - safe_sql.py: Add ordered-set aggregate functions - top_queries_calc.py: Use version-appropriate column name for stddev - docker-entrypoint.sh: Use exec for proper signal handling - Dockerfile: Create app user before COPY with --chown - sequence_health_calc.py: Fix parsing of quoted identifiers - server.py: Add configurable timeout, table/column comments in metadata - __init__.py: Configure logging to stderr - README.md: Add uvx/WSL instructions, fix broken links
2 tasks
Contributor
|
Thanks for identifying this issue and providing the initial fix! I've created #128 which builds on your work with improved test coverage (keeps the original lowercase test case and adds a separate uppercase test table). Closing this in favor of that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, this code didn't handle sequence names that need to be quoted due to upper case characters.
I've changed one of the test tables to use upper case so that this functionality can be verified.