a3-lbodwell-luke-bodwell #89
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that there are two commits that were made after the due date. One was to fix a typo in the title of the login page and didn't affect the functionality of the application in any meaningful way. The second was a bit more substantial and fixed a bug in which data was not populated on the initial page load. This happened as a result of fixing another bug shortly before the due date that I did not thoroughly test. I was updating the page every 10 seconds with new data. I ended up removing this functionality as the application would rebuild the data table when it refreshed and would automatically scroll the table to the first entry. This behavior was cumbersome and I decided that it was better to just drop support for updating data automatically than to keep it. I also accidentally deleted the window.onload event in the process. I added it back and it just calls one function--a rather trivial fix, however I understand if this can not be factored in to my grade for the project. I apologize for any inconvenience.