Fix LDAP encryption settings translation for net-ldap 0.16 #264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to configure LDAP to ignore the certificate validation in development mode when using LDAPS and a test server and used the following keys in my
ldap.yml
to set the encryption:However, because the YAML file is interpreted with string values, it was not compatible with
net-ldap
which always expects symbols. As a fix I updatedldap/connection.rb
to translate the config to symbols if the encryption key is present. I am aware that this only takes this one use case into account and would love to extend or generalise it, if someone proposes a better approach or knows what's necessary to make the gem officially supportnet-ldap 0.16
. But I thought that it might already be helpful to some in this version.