Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LDAP encryption settings translation for net-ldap 0.16 #264

Open
wants to merge 1 commit into
base: default
Choose a base branch
from

Conversation

irruputuncu
Copy link

I tried to configure LDAP to ignore the certificate validation in development mode when using LDAPS and a test server and used the following keys in my ldap.yml to set the encryption:

  encryption:
    method: simple_tls
    tls_options:
      verify_mode: OpenSSL::SSL::VERIFY_NONE

However, because the YAML file is interpreted with string values, it was not compatible with net-ldap which always expects symbols. As a fix I updated ldap/connection.rb to translate the config to symbols if the encryption key is present. I am aware that this only takes this one use case into account and would love to extend or generalise it, if someone proposes a better approach or knows what's necessary to make the gem officially support net-ldap 0.16. But I thought that it might already be helpful to some in this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant