Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update copy command and fix some bugs #117

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update copy command and fix some bugs #117

wants to merge 5 commits into from

Conversation

ngoctint1lvc
Copy link

  • When pressing 'c', we should copy the originalText instead of the translation results
  • Fix bug cannot show some popups in bilibili
Screenshot 2024-06-08 at 20 59 15

@ngoctint1lvc ngoctint1lvc force-pushed the master branch 2 times, most recently from 334671b to 4885ab5 Compare June 9, 2024 15:49
@ngoctint1lvc ngoctint1lvc force-pushed the master branch 3 times, most recently from a7f5454 to fe24bbd Compare June 12, 2024 20:22
cschiller
cschiller reviewed Nov 12, 2024
View reviewed changes
Copy link
Owner

@cschiller cschiller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you want to disable the 'a' key? It's a useful feature.

@cschiller
Copy link
Owner

When pressing 'c', the translation if copied on purpose. This is by design. It can be used to save dictionary entries in a text file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cschiller cschiller cschiller left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngoctint1lvc @cschiller