Handle content in iframes #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This later change seems to fix highlighting selected text in the iframe and, I hope, avoids trying to modify the iframe if it is a different domain. Also, I made the mistake of committing a .vimrc, which I have now removed from the history, thus the force push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only tested in Firefox 91.4.1esr 64bit, against my Calibre-Web website but in this case it supports lookup for content in the embedded iframe and handles the iframe being removed and recreated when the browser window size changes. I have only tested character lookup because I have only used character lookup. In particular, I haven't tried any of the keyboard shortcuts to ensure they work for content in an iframe.
Much of this is new to me and I don't have knowledge or expertise to suggest that this is a good solution but it does seem to be working for me. If you find any faults in the implementation, I would be pleased to hear about them. Otherwise, I hope this helps you towards an enhancement to address the limitation reported in issue #85, should you be so inclined. And thank you for a great add-on, in any case.