Skip to content

Add enable_observer_from_this and fix self assignment/swap #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 11, 2021

Conversation

cschreib
Copy link
Owner

This PR brings enable_observer_from_this, to create observer pointer from within a class, and fixes bugs related to self assignment and self swap. It also fixes a mismatch between new[] and delete for the sealed pointer, which was reported by valgrind.

@codecov-commenter
Copy link

Codecov Report

Merging #3 (91ef2e1) into main (c8acb1f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          268       275    +7     
=========================================
+ Hits           268       275    +7     
Impacted Files Coverage Δ
include/oup/observable_unique_ptr.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8acb1f...91ef2e1. Read the comment docs.

@cschreib cschreib merged commit b697b94 into main Nov 11, 2021
@cschreib cschreib deleted the enable_observer_from_this branch November 11, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants