Skip to content

Bug fixes for enable_observer_from_this #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 13, 2021

Conversation

cschreib
Copy link
Owner

Small changes and bug fixes:

  • Fixed observable_unique_ptr::reset(T*) incorrectly marked noexcept.
  • Fixed enable_observable_from_this not supporting multiple inheritance, or storage in base-class owner pointer.
  • Decreased memory usage of enable_observable_from_this.
  • Added explicit checks against T[] since arrays are not supported.
  • Fixed documentation errors

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2021

Codecov Report

Merging #4 (726c5a7) into main (b697b94) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          275       285   +10     
=========================================
+ Hits           275       285   +10     
Impacted Files Coverage Δ
include/oup/observable_unique_ptr.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b697b94...726c5a7. Read the comment docs.

@cschreib cschreib merged commit a1c175e into main Nov 13, 2021
@cschreib cschreib deleted the enable_observer_from_this_optim branch November 13, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants