Conversation
Contributor
Author
|
@chipbarnaby, the test failures here are very puzzling to me. Here are the files that are failing: All of these except 48 have 0.01 differences in Test 48 is probably worth a call to go over. The test file has 5 separate runs where the meter reports for each run are identical, but the UDT reports have diffs for all except the last run. |
chipbarnaby
reviewed
Dec 29, 2021
Contributor
chipbarnaby
left a comment
There was a problem hiding this comment.
I agree that the ashp_dfng changes are suspicious.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently limited to RS0004 (Unitary Air Conditioning). Added new test file
205Test.cse.Author Progress Checklist:
Reviewer Checklist: