Open
Conversation
galanCA
added
maintenance
multi-platform
tanaya-mankad
approved these changes
Aug 16, 2022
nealkruis
requested changes
Nov 21, 2022
Contributor
nealkruis
left a comment
nealkruis
left a comment
There was a problem hiding this comment.
Still needs error tests.
nealkruis
requested changes
Nov 21, 2022
| if (yac) | ||
| { if ( hdr // if header given | ||
| { | ||
| #if 0 |
Contributor
There was a problem hiding this comment.
This needs comments to explain why it's #ifd out.
| if (mFh >= 0) | ||
| { if (_lseek( mFh, 0, SEEK_SET) == -1L) | ||
| if (mFh) | ||
| { if (fseek( mFh, 0, SEEK_SET) != 0) |
Contributor
There was a problem hiding this comment.
Is this line hit in the tests?
| rc = errFl((const char *)MH_I0104); // seek failed, conditionally issue error msg containing "Seek error on" | ||
|
|
||
| int nw = ::write( mFh, yc_buf, bufN); // write buffer contents, return -1 or # bytes written. C library function. | ||
| int nw = fwrite( yc_buf, sizeof(char), bufN, mFh); // write buffer contents, return -1 or # bytes written. C library function. |
Contributor
There was a problem hiding this comment.
is this line hit in the tests?
| (char *)MH_I0118, // "%s '%s' (near line %d):\n %s" | ||
| mWhat, mPathName ? mPathName : "bug", mLineNo, buf ); | ||
| } | ||
| #if 0 // Methonds not used, but were modified to fit c-style io, not tested. sha d06014d81f75e5ec2b9d4e31750dd0c076afae46 |
Contributor
There was a problem hiding this comment.
- Spell check
- Is "c-style io" the right term?
- Do we need the sha here? Generally we only need a sha if we're deleting something.
Contributor
There was a problem hiding this comment.
I think we settled on not putting SHAs in comments because version control systems are not forever.
Contributor
There was a problem hiding this comment.
That's been Chip's argument for a while. I thought that if we did something like this, we'd just mention that last release version where the code appeared.
| int mErOp; // communicates erOp from entry points to error fcns | ||
| // note need a data mbr at end due to rcdef.exe deficiency 10-94. | ||
|
|
||
| #if 0 // Methonds not used, but were modified to fit c-style io, not tested. sha d06014d81f75e5ec2b9d4e31750dd0c076afae46 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces windows file system functions for C standard functions.
Test
The following tests are checked using a breakpoint.
The following tests are not stopped during the run test. Thus they are if-out from CSE, until future use.
Author Progress Checklist:
Reviewer Checklist: