Skip to content

Add rsHSPF requirement when rsType = ASHPPM.#593

Merged
chipbarnaby merged 1 commit intomainfrom
update-docs-rshspf
Jan 16, 2026
Merged

Add rsHSPF requirement when rsType = ASHPPM.#593
chipbarnaby merged 1 commit intomainfrom
update-docs-rshspf

Conversation

@nathancoliver
Copy link
Member

Description

I tried creating an RSYS object with rsType = ASHPPM. I got the following error.

S0497: 'rsHSPF' missing: required when rsType=ASHPPM

I noticed the docs did not mention rsHSPF is required when rsType = ASHPPM, so I fixed it.

Author Progress Checklist:

  • Open draft pull request
    • Make title clearly understandable in a standalone change log context
    • Assign yourself the issue
    • Add at least one label (enhancement, bug, or maintenance)
    • Link the issue(s) addressed by this PR (under "Development" in the sidebar menu)
  • Make code changes (if you haven't already)
  • Self-review of code
    • My code follows the style guidelines of this project
    • I have added comments to my code, particularly in hard-to-understand areas
    • I have only committed the necessary changes for this fix or feature
    • I have made corresponding changes to the documentation
    • My changes generate no new warnings
    • I have ensured that my fix is effective or that my feature works as intended by:
      • exercising the code changes in the test framework, and/or
      • manually verifying the changes (as explained in the the pull request description above)
    • My changes pass all local tests
    • My changes successfully passes CI checks
    • Add any unit test for proof and documentation.
    • Merge in main branch and address resulting conflicts and/or test failures.
  • Move pull request out of draft mode and assign reviewers
  • Iterate with reviewers until all changes are approved
    • Make changes in response to reviewer comments
    • Merge in main branch and address resulting conflicts and/or test failures.
    • Re-request review in GitHub

Reviewer Checklist:

  • Read the pull request description
  • Perform a code review on GitHub
  • Confirm all CI checks pass and there are no build warnings
  • Pull, build, and run automated tests locally
  • Perform manual tests of the fix or feature locally
  • Add any review comments, if applicable
  • Submit review in GitHub as either
    • Request changes, or
    • Approve
  • Iterate with author until all changes are approved

@nealkruis
Copy link
Contributor

I think the better fix here would be to remove the requirement in the code. @chipbarnaby?

@chipbarnaby chipbarnaby merged commit 5989672 into main Jan 16, 2026
3 checks passed
@chipbarnaby chipbarnaby deleted the update-docs-rshspf branch January 16, 2026 18:27
@chipbarnaby
Copy link
Contributor

chipbarnaby commented Jan 16, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants