RSYS indoor condition adjustment ("Cutler curve") fixes#597
Merged
chipbarnaby merged 4 commits intomainfrom Jan 21, 2026
Merged
RSYS indoor condition adjustment ("Cutler curve") fixes#597chipbarnaby merged 4 commits intomainfrom
chipbarnaby merged 4 commits intomainfrom
Conversation
chipbarnaby
changed the title
nealkruis
approved these changes
Jan 21, 2026
|
|
||
| // use correlations to get adjustments for entering air state | ||
| // "Cutler curve" correlations to get adjustments for entering air state | ||
| rs_CoolingEnteringAirFactorsVC(rs_fCondCap, rs_fCondInp); |
Contributor
There was a problem hiding this comment.
Probably should eventually change the name here since it isn't specific to "VC".
| } // RSYS::rs_PerfASHP | ||
| //------------------------------------------------------------------------------ | ||
| float RSYS::rs_PerfASHP2( // ASHP performance | ||
| float RSYS::rs_PerfASHP2( // ASHP heating performance |
Contributor
There was a problem hiding this comment.
Update function name here too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Several fixes in RSYS performance map model calc sequence wrt indoor condition adjustments.
Some additional RSYS cleanup.
Added ACCUMULATOR acmCond logic to support conditional value tracking.
ACCUMULATOR documentation updated.
Modest heating results changes for cases using RSYS performance map model. Many other infinitesimal results changes.