fix(interp): deftype fails at its own form with a locating error - #355
Merged
Conversation
deftype was a builtin wired to a nil stub, so (deftype T [x y]) took the function-application path, evaluated its args, and died on the unbound symbol T with "Unable to resolve symbol: T" — an error that names a symbol and points nowhere near the real cause. deftype is genuinely unimplemented (it needs mutable/volatile fields, set! over them, and array interop). Made it a special form that returns "deftype is not implemented (defining T); use defrecord where a map-backed type suffices" without evaluating its args, so the failure lands on the deftype line and says what is actually missing. Removed the unreachable builtin registration. defrecord and reify unaffected; suite 431/431.
csm
self-requested a review
August 29, 2026 04:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deftype was a builtin wired to a nil stub, so (deftype T [x y]) took the
function-application path, evaluated its args, and died on the unbound symbol T
with "Unable to resolve symbol: T" — an error that names a symbol and points
nowhere near the real cause. deftype is genuinely unimplemented (it needs
mutable/volatile fields, set! over them, and array interop).
Made it a special form that returns "deftype is not implemented (defining T);
use defrecord where a map-backed type suffices" without evaluating its args, so
the failure lands on the deftype line and says what is actually missing.
Removed the unreachable builtin registration. defrecord and reify unaffected;
suite 431/431.