-
Notifications
You must be signed in to change notification settings - Fork 63
Example new structure #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[1] Pending the reviews of the files. |
|
Hi @pritkc , thank you for opening the PR. I would modify the Also, referring to the libCEED model, I would also add to the toc the individual subdirectory |
|
Also, I think we need to move the content out of |
|
Hi @valeriabarra, Thank you for reviewing these changes thoroughly. Adding a few follow-up questions on quotes.
[1] Should I be moving individual Markdown examples to their MATLAB host directories? Considering we won't have any single C++ examples that are not available with its MATLAB counterpart.
[2] Following my question [1], should I assume we're not making any
[3] Would it be better if I added that description under |
a7d8df8 to
d5e6374
Compare
|
@valeriabarra This branch has been tested and is ready for your review.
Pending --
|
|
Will close #135 as well |
bd7b016 to
b7b9a4d
Compare
b7b9a4d to
ee3f952
Compare
|
@valeriabarra The above feedback and the duplicate |
valeriabarra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent job, @pritkc !!
What type of PR is this? (check all applicable)
Description
Related Issues & Documents
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.
Added/updated tests?
_We encourage you to test all code included with MOLE, including examples.
have not been included
Read Contributing Guide and Code of Conduct
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?