Skip to content

Conversation

@pritkc
Copy link
Collaborator

@pritkc pritkc commented Apr 30, 2025

What type of PR is this? (check all applicable)

  • Refactor
  • [] Feature
  • Bug Fix
  • Optimization
  • Example
  • Documentation

Description

Related Issues & Documents

  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

_We encourage you to test all code included with MOLE, including examples.

  • Yes
  • [ X ] No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Read Contributing Guide and Code of Conduct

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@pritkc
Copy link
Collaborator Author

pritkc commented Apr 30, 2025

[1] Pending the reviews of the files.
[2] Upon completion of [1], the existing static paths to the examples (i.e., sphinx direct calls) will be replaced.

@valeriabarra
Copy link
Collaborator

Hi @pritkc , thank you for opening the PR.

I would modify the examples/index.md file with a bit of description of the directory tree. For instance, that we organize examples by PDE-type and then by dimensionality.

Also, referring to the libCEED model, I would also add to the toc the individual subdirectory index.md files for our subdirectories. Thank you

@valeriabarra
Copy link
Collaborator

Also, I think we need to move the content out of examples/examples.md to the different relevant subdirectories

@pritkc
Copy link
Collaborator Author

pritkc commented Apr 30, 2025

Hi @valeriabarra, Thank you for reviewing these changes thoroughly. Adding a few follow-up questions on quotes.

Also, I think we need to move the content out of examples/examples.md to the different relevant subdirectories

[1] Should I be moving individual Markdown examples to their MATLAB host directories? Considering we won't have any single C++ examples that are not available with its MATLAB counterpart.

Also, referring to the libCEED model, I would also add to the toc the individual subdirectory index.md files for our subdirectories.

[2] Following my question [1], should I assume we're not making any index.md directories for C++ directories?

I would modify the examples/index.md file with a bit of description of the directory tree. For instance, that we organize examples by PDE-type and then by dimensionality.

[3] Would it be better if I added that description under Readme? For the Sphinx, we will be adding the index below the README, so both files will be served on the examples homepage.

@pritkc pritkc force-pushed the example-new-structure branch from a7d8df8 to d5e6374 Compare May 20, 2025 21:08
@pritkc
Copy link
Collaborator Author

pritkc commented May 20, 2025

@valeriabarra This branch has been tested and is ready for your review.
Changes from the last post review :

  1. Retained the original directory structure of matlab and C++ API examples
  2. Moved the examples-doc inside the Sphinx
  3. Added new examples; now each category has at least one example for it.
  4. Repaired the linker references; now they link to their master GH repo
  5. Improved the TOC tree structure for better visibility of sections.
  6. Tested and rebased up to date with the master

Pending --

  1. Pre-merger squash, there are no isolated commit requirements for this work. You may squash everything if no further improvements are needed.

@pritkc
Copy link
Collaborator Author

pritkc commented May 21, 2025

Will close #135 as well

@pritkc pritkc force-pushed the example-new-structure branch from bd7b016 to b7b9a4d Compare May 23, 2025 21:58
@pritkc pritkc force-pushed the example-new-structure branch from b7b9a4d to ee3f952 Compare May 23, 2025 22:58
@pritkc
Copy link
Collaborator Author

pritkc commented May 23, 2025

@valeriabarra The above feedback and the duplicate graphviz have been taken care of with this last push.

@pritkc pritkc marked this pull request as ready for review May 23, 2025 23:02
Copy link
Collaborator

@valeriabarra valeriabarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job, @pritkc !!

@pritkc pritkc merged commit 6b2080e into master May 28, 2025
25 of 27 checks passed
@pritkc pritkc deleted the example-new-structure branch May 29, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants