Skip to content

Conversation

@Shane-Stevenson
Copy link
Contributor

@Shane-Stevenson Shane-Stevenson commented Dec 3, 2025

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Example
  • Documentation

Description

3rd PR of 4 examples

Added example elliptic1DLeftDirichletRightNeumann.cpp. Updated example documentation by linking example.

Related Issues & Documents

QA Instructions, Screenshots, Recordings

Build and run example binary

Added/updated tests?

_We encourage you to test all code included with MOLE, including examples.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Read Contributing Guide and Code of Conduct

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@Shane-Stevenson Shane-Stevenson force-pushed the stevenson/elliptic1DLeftDirichletRightNeumann branch from 1131e80 to b0dcf5c Compare December 3, 2025 06:31
@Shane-Stevenson Shane-Stevenson force-pushed the stevenson/elliptic1DLeftDirichletRightNeumann branch from b0dcf5c to b74c7a0 Compare December 3, 2025 06:57
@Shane-Stevenson
Copy link
Contributor Author

Shane-Stevenson commented Dec 3, 2025

There are some discrepancies between my code here, the docs, and the MATLAB example. As given by the name of the example, this problem has left Dirichlet and right Neumann conditions. However, it seems to me like the documentation and the MATLAB example have a left Neumann and a right Dirichlet. Thus, my written example here does NOT match the linked documentation. Please let me know what I should do or if I am misunderstanding.

@jbrzensk
Copy link
Collaborator

jbrzensk commented Dec 3, 2025

No @Shane-Stevenson , you did it correct. The other code is incorrectly named. I made an issue ( #245 ). Thanks!

@Shane-Stevenson
Copy link
Contributor Author

No @Shane-Stevenson , you did it correct. The other code is incorrectly named. I made an issue ( #245 ). Thanks!

According to #245 the solution is to rename these files. This means my code should be changed to have a left Neumann and Right Dirichlet in order to match the MATLAB example and corresponding documentation, right?

@valeriabarra
Copy link
Collaborator

No @Shane-Stevenson , you did it correct. The other code is incorrectly named. I made an issue ( #245 ). Thanks!

According to #245 the solution is to rename these files. This means my code should be changed to have a left Neumann and Right Dirichlet in order to match the MATLAB example and corresponding documentation, right?

Hi @Shane-Stevenson Thank you for all your contributions! Yes, I would have your code reflect the MATLAB code and we will simply rename the MATLAB file name and update its documentation in a separate PR. Thank you for bringing up the discrepancy

@jbrzensk jbrzensk merged commit 61a612b into csrc-sdsu:main Dec 5, 2025
6 checks passed
@jbrzensk jbrzensk mentioned this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants