Skip to content

Conversation

@joehellmersNOAA
Copy link
Collaborator

@joehellmersNOAA joehellmersNOAA commented Dec 15, 2025

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Example
  • Documentation

Description

Related Issues & Documents

  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

_We encourage you to test all code included with MOLE, including examples.

  • Yes
  • No, and this is why: Current test coverage should be sufficient
  • I need help with writing tests

Read Contributing Guide and Code of Conduct

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@joehellmersNOAA
Copy link
Collaborator Author

This PR should resolve issue #251

@jbrzensk
Copy link
Collaborator

Does this work for you @joehellmersNOAA , with gcc15+?
To check, you only have to see if the examples with 'solve' run. We assume SuperLU will solve it correctly.

We will also need a test on intel and mac silicon

@joehellmersNOAA joehellmersNOAA marked this pull request as ready for review December 17, 2025 16:44
@joehellmersNOAA joehellmersNOAA merged commit 542239e into csrc-sdsu:dev/upd-cpp-dependencies Dec 17, 2025
11 checks passed
jbrzensk added a commit that referenced this pull request Dec 22, 2025
Update SuperLU and Armadillo versions (#254)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants