adding hyperbolic1D_upwind.cpp

[edfink234]

This PR would like to add hyperbolic1D_upwind.cpp as the C++ version of hyperbolic1D_upwind.m. This addresses issue #62

[jbrzensk]

This need to be updated ith the latest commits in MOLE, and can you implement the same looping structure you did with RK2, so there is no need for #include <thread>

You can pass loop commands to gnuplot in the script, the following has the output called "gp_script", but the point is the same:

    dataFile << "set terminal qt\n";
    dataFile << "set xlabel 'x'\n";
    dataFile << "set ylabel 'u(x,t)'\n";
    dataFile << "set xrange [0.0:1.0]\n";
    dataFile << "set yrange [-1.5:1.5]\n";
    dataFile << "set grid\n";
    dataFile << "do for [i=0:" << steps << "] {\n";
    dataFile << "    plot 'results.dat' index i using 1:2 with linespoints title sprintf('t = %.2f', i*" << dt << ")\n";
    dataFile << "    pause 0.1\n";
    dataFile << "}\n";

[edfink234]

Ok, I think I've fixed it, please lmk if it looks good.

[mdumett]

Please, even though that is not in the comments of the MATLAB code, indicate in the top comments of your code which equation is being solved, its time and space domains and its initial and boundary conditions.

[edfink234]

Please, even though that is not in the comments of the MATLAB code, indicate in the top comments of your code which equation is being solved, its time and space domains and its initial and boundary conditions.

Thanks for the feedback! I just added this.

[mdumett]

1. There are some constants in your code whose value are known before compilation.
2. These should be constexpr, like the constant pi. In addition, could results.dat and gp_script be defined as constants?
3. Look into cstdlib for return code EXIT_FAILURE and/or EXIT_SUCCESS

[edfink234]

1. There are some constants in your code whose value are known before compilation.
2. These should be constexpr, like the constant pi. In addition, could results.dat and gp_script be defined as constants?
3. Look into cstdlib for return code EXIT_FAILURE and/or EXIT_SUCCESS

I added this! The variables for the results.dat and gp_script files cannot be made const because of their non-const ostream member operators.

[mdumett]

Please, merge your code

[edfink234]

Please, merge your code

sorry, how do I do this?

[mdumett]

Just take a look at the green button (Merge pull request) at the end of the pull request conversations

[edfink234]

I don't see this, and I don't think I have this permission...