updates boundary info into discrete analog system #66
Conversation
addBC functionality adds boundary information into the discrete analog of the PDE, both operator and rhs
jbrzensk
left a comment
jbrzensk
left a comment
There was a problem hiding this comment.
Some of the codes use a interpolated that you probably just named different than the library.
Things that would make this perfect would be a 2D or 3D Neumann example, AND take an existing example, and show how to use the new boundary operators with it. Like how we do multiple version of wave equation, pick a varaiety and show how to use these new operators.
Corrected function names and added four examples: two are old ones written with addBC instead of robinBC, one 1D wave equation using addBC and one 3D with Neumann and periodic BC
Will need time to review. If somebody else can take a look at it that will be awesome 👍 |
|
This PR adds a lot of files to the examples folder. Why don't we organize the examples into separate folders? |
|
Do you mean to organize all the examples (the ones that existed before and the ones contributed in this PR)? If that is the case, we could think organizing all examples by types, for example, elliptic, parabolic, hyperbolic, specific equations, etc. |
Yes, "organizing all examples by types, for example, elliptic, parabolic, hyperbolic, specific equations, etc." is what I meant. |
addBC functionality adds boundary information into the discrete analog of the PDE, both operator and rhs