Burgers1D example in C++

[arrowguy234]

This pull request corresponds to issue #70

[mdumett]

The sizes of the vectors and matrix consider 302 points and not 301. Please, run the MATLAB version to check the correct sizes of each array

[arrowguy234]

@pritkc All changes done

[mdumett]

Please, even though that is not in the comments of the MATLAB codes, indicate in the top comments of each of your codes which equation is being solved, its time (if required) and space domains and its initial (if required) and boundary conditions.

[arrowguy234]

@mdumett Equation and conditions added professor.

[arrowguy234]

@pritkc Hello , I had a request that if its possible can I get review of my code for the equations because I made the changes suggested.

Regards
Surinder

[pritkc]

@pritkc Hello , I had a request that if its possible can I get review of my code for the equations because I made the changes suggested.

Regards Surinder

You may have to reach out to @mdumett. In the meantime, you may retire your makefile and rebase your branch as we have moved to the new CMake system.

[arrowguy234]

@pritkc @mdumett I have retired my old makefile and also tested my code on new Make system based in Ubuntu as well as WSL, @JananiPSrinivasan has verified the working.

Rebase request fullfilled

[mdumett]

Use constexpr in the Burgers example.

[jbrzensk]

If you want to split this into 2 pull requests, the POisson2D seems good to go with the name change. Burgers1D needs more work.

[arrowguy234]

@jbrzensk @mdumett ll requested changes have been completed.
In Burgers1D, terminal output now only prints example values instead of every line.
constexpr has been used where applicable.
The Poisson file has been renamed for clarity.
Let me know if there are any other suggestions or improvements needed.

[mdumett]

@arrowguy234: Burgers1D.m has a plot instead of examples values. Use gnuplot for plotting every 5 iterations. In addition, the matlab/octave code prints the value of the area under the curve using the trapezoidal rule which is missing in the C++ code. Implementing that function in C++ is not difficult. See https://en.wikipedia.org/wiki/Trapezoidal_rule . You can add that function in utils.cpp and utils.h

[arrowguy234]

@mdumett Thanks a lot for your input, I have implemented the trapezoid rule in Utils file as well as included it in my Burgers1D code and along with that, the output is being printed in a graph plot like matlab, I'm happy to take on any additional suggestions or structural improvements you might have.

[mdumett]

Thank you for addressing all comments

[mdumett]

Please, reuse D and that should be it.

[arrowguy234]

@mdumett @aboada All suggested changes done, if anything looks out of place please suggest more changes.