Skip to content

Commit

Permalink
refactor(cubesql): Remove Extension from LogicalPlanLanguage::CubeScan
Browse files Browse the repository at this point in the history
Extensions is used meaningfully only for CubeScan, but not for CubeScanWrapper. Both are first-class logical plan nodes for us, so Extension is not helpful in egraph
  • Loading branch information
mcheshkov committed Oct 4, 2024
1 parent da70a8e commit 499510b
Show file tree
Hide file tree
Showing 3 changed files with 468 additions and 530 deletions.
1 change: 0 additions & 1 deletion rust/cubesql/cubesql/src/compile/rewrite/analysis.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1221,7 +1221,6 @@ impl LogicalPlanAnalysis {
Some(c.to_string())
}
LogicalPlanLanguage::CubeScan(params) => cube_reference(params[0]),
LogicalPlanLanguage::Extension(params) => cube_reference(params[0]),
_ => None,
}
}
Expand Down
Loading

0 comments on commit 499510b

Please sign in to comment.