Skip to content

Commit

Permalink
Add usefull comments
Browse files Browse the repository at this point in the history
  • Loading branch information
KSDaemon committed Sep 13, 2024
1 parent 288f445 commit 7691704
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
Original file line number Diff line number Diff line change
Expand Up @@ -2199,7 +2199,7 @@ export class BaseQuery {
const memberPathArray = [cubeName, name];
// Member path needs to be expanded to granularity if subPropertyName is provided.
// Without this: failures with Maximum call stack size exceeded.
// During resolving and members collection safeEvaluateSymbolContext().memberChildren is set,
// During resolving within dimensionSql() and members collection safeEvaluateSymbolContext().memberChildren is set,
// so path is recursively pushed to memberChildren.
if (subPropertyName && symbol.type === 'time') {
memberPathArray.push('granularities', subPropertyName);
Expand Down

0 comments on commit 7691704

Please sign in to comment.