Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schema-compiler): Support date_bin function in Cube Store queries #8684

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Sep 9, 2024

This PR brings date_bin() support to CubeStoreQuery. This makes sense for Custom Granularities.

Related to:

Depends on:

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@KSDaemon KSDaemon requested review from a team as code owners September 9, 2024 14:33
Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 9:07am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 9:07am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 9:07am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 9:07am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 9:07am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 9:07am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 9:07am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 9:07am

@KSDaemon KSDaemon changed the base branch from master to proxy-granularities September 9, 2024 14:33
@ovr ovr changed the title feat/date bin cubestorequery feat(cubestore): Support date_bin function Sep 11, 2024
@ovr ovr changed the title feat(cubestore): Support date_bin function feat: Support custom granularities for Cube Store Sep 11, 2024
@KSDaemon KSDaemon requested review from a team as code owners September 13, 2024 08:51
@KSDaemon KSDaemon changed the base branch from proxy-granularities to master September 13, 2024 08:52
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.61%. Comparing base (841f59a) to head (f8c2d25).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8684      +/-   ##
==========================================
- Coverage   82.62%   82.61%   -0.01%     
==========================================
  Files         212      212              
  Lines       77343    77343              
==========================================
- Hits        63905    63898       -7     
- Misses      13438    13445       +7     
Flag Coverage Δ
cubesql 82.61% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KSDaemon KSDaemon changed the title feat: Support custom granularities for Cube Store feat(schema-compiler): custom granularity support for Cube Store queries Sep 13, 2024
@KSDaemon KSDaemon changed the title feat(schema-compiler): custom granularity support for Cube Store queries feat(schema-compiler): Support date_bin function in Cube Store queries Sep 13, 2024
@KSDaemon KSDaemon merged commit f7c07a7 into master Sep 13, 2024
49 checks passed
@KSDaemon KSDaemon deleted the feat/date_bin_cubestorequery branch September 13, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants