feat(cubesql): Top-down extractor for rewrites #8694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8694 +/- ##
==========================================
- Coverage 82.73% 82.67% -0.07%
==========================================
Files 221 221
Lines 78280 78554 +274
==========================================
+ Hits 64768 64946 +178
- Misses 13512 13608 +96
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MazterQyou
force-pushed
the
cubesql/top-down-cost
branch
from
5a05dae
to
1b256a7
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
MazterQyou
force-pushed
the
cubesql/top-down-cost
branch
2 times, most recently
from
dd6ec21
to
157ad9f
Compare
MazterQyou
force-pushed
the
cubesql/top-down-cost
branch
2 times, most recently
from
c54113c
to
2fcd242
Compare
ovr
approved these changes
Oct 9, 2024
MazterQyou
force-pushed
the
cubesql/top-down-cost
branch
from
2fcd242
to
693d7d0
Compare
MazterQyou
force-pushed
the
cubesql/top-down-cost
branch
from
693d7d0
to
d90a615
Compare
ovr
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made
This PR adds a top-down extractor for e-graphs in addition to the previously used bottom-up extractor. This allows extracting nodes from e-classes with respect to their state. Use flag
CUBESQL_TOP_DOWN_EXTRACTOR=trueto enable.