Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Support new meta queries for QuickSight's Redshift driver #8716

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

MazterQyou
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR fixes compatibility with QuickSight's Redshift driver by supporting new meta queries. Changes include:

  • pg_catalog.pg_external_schema meta table support
  • information_schema.sql_sizing meta table support
  • stv_slices meta table support
  • regexp_instr function execution support
  • workarounds for Redshift-specific behavior: FROM subquery without an alias, self-referencing expressions in SELECT, WHERE expressions referencing SELECT expressions by alias

Related tests are included.

@MazterQyou MazterQyou requested a review from a team as a code owner September 17, 2024 00:06
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 91.16998% with 40 lines in your changes missing coverage. Please review.

Project coverage is 82.67%. Comparing base (7096242) to head (fd668e6).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
...cubesql/cubesql/src/compile/engine/udf/redshift.rs 79.12% 19 Missing ⚠️
.../information_schema/redshift/pg_external_schema.rs 84.48% 9 Missing ⚠️
...e/engine/information_schema/redshift/stv_slices.rs 86.36% 9 Missing ⚠️
...e/engine/information_schema/postgres/sql_sizing.rs 97.43% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8716      +/-   ##
==========================================
+ Coverage   82.62%   82.67%   +0.04%     
==========================================
  Files         212      216       +4     
  Lines       77343    78061     +718     
==========================================
+ Hits        63906    64536     +630     
- Misses      13437    13525      +88     
Flag Coverage Δ
cubesql 82.67% <91.16%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MazterQyou MazterQyou merged commit 148e4cf into master Sep 17, 2024
67 checks passed
@MazterQyou MazterQyou deleted the cubesql/quicksight-fix branch September 17, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants