refactor(cubesql): Use Default struct update for V1LoadRequestQuery in tests #8836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8836 +/- ##
==========================================
- Coverage 82.69% 82.55% -0.15%
==========================================
Files 221 221
Lines 78609 77830 -779
==========================================
- Hits 65006 64249 -757
+ Misses 13603 13581 -22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…n test_bi_workarounds
…n test_user_change
…n bulk of rewrite tests
mcheshkov
force-pushed
the
tests-load-query-with-default
branch
from
cb67ba6
to
f75f7e3
Compare
ovr
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow to change fields in
V1LoadRequestQuerywithout massive changes in test.Every field in query is optional, and
Defaultis derived, so it would just mean "empty query", and each test case will fill only non-empty parts.