Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Initial SQL pushdown flattening #8888

Merged
merged 9 commits into from
Nov 13, 2024

Conversation

mcheshkov
Copy link
Member

@mcheshkov mcheshkov commented Oct 31, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

Flatten Aggregation(Filter(CubeScan)) to a single CubeScanWrapper(push_to_cube=true)

Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 0:34am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 0:34am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 0:34am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 0:34am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 0:34am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 0:34am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 0:34am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 0:34am

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 97.90076% with 22 lines in your changes missing coverage. Please review.

Project coverage is 82.66%. Comparing base (a7bab04) to head (77e4461).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...c/compile/rewrite/rules/wrapper/scalar_function.rs 81.57% 7 Missing ⚠️
...l/cubesql/src/compile/rewrite/rules/wrapper/mod.rs 95.77% 3 Missing ⚠️
...besql/src/compile/rewrite/rules/wrapper/literal.rs 94.87% 2 Missing ⚠️
rust/cubesql/cubesql/src/compile/engine/df/scan.rs 66.66% 1 Missing ⚠️
...sql/src/compile/rewrite/rules/wrapper/aggregate.rs 99.55% 1 Missing ⚠️
...ubesql/src/compile/rewrite/rules/wrapper/filter.rs 98.52% 1 Missing ⚠️
.../src/compile/rewrite/rules/wrapper/in_list_expr.rs 96.00% 1 Missing ⚠️
.../compile/rewrite/rules/wrapper/in_subquery_expr.rs 96.15% 1 Missing ⚠️
...cubesql/src/compile/rewrite/rules/wrapper/order.rs 96.77% 1 Missing ⚠️
...ql/src/compile/rewrite/rules/wrapper/projection.rs 98.41% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8888      +/-   ##
==========================================
+ Coverage   82.55%   82.66%   +0.11%     
==========================================
  Files         221      221              
  Lines       77734    78324     +590     
==========================================
+ Hits        64174    64750     +576     
- Misses      13560    13574      +14     
Flag Coverage Δ
cubesql 82.66% <97.90%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov marked this pull request as ready for review November 8, 2024 02:13
@mcheshkov mcheshkov requested a review from a team as a code owner November 8, 2024 02:13
@mcheshkov mcheshkov merged commit 211d1c1 into master Nov 13, 2024
74 checks passed
@mcheshkov mcheshkov deleted the wrapper-initial-flattening branch November 13, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants