-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(schema-compiler): Fix inherited drill members for views #9966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
16db64a
to
ca9d3b7
Compare
…rror reporting # Conflicts: # packages/cubejs-schema-compiler/src/compiler/ErrorReporter.ts
4e37f9d
to
25fd1d2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9966 +/- ##
===========================================
- Coverage 77.13% 48.73% -28.40%
===========================================
Files 440 196 -244
Lines 89307 15840 -73467
Branches 3101 3106 +5
===========================================
- Hits 68889 7720 -61169
+ Misses 20029 7728 -12301
- Partials 389 392 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR supersedes the original one by @paco-valdez.
Updated with a simpler one-time drillMembers evaluation.
Fixes #6778.
Closes #9959.
Check List