Bug Fix. }bedrock.hier.unwind does nothing (and does not error) under certain parameters#447
Open
bdunleavy22 wants to merge 1 commit into
Open
Bug Fix. }bedrock.hier.unwind does nothing (and does not error) under certain parameters#447bdunleavy22 wants to merge 1 commit into
bdunleavy22 wants to merge 1 commit into
Conversation
… certain parameters if pDelim = '' and pHier = '' and pDim is one dimension (no delimiter or wildcard characters and does not specify a hierarchy with ':') and pConsol is '*', then all the places pHier gets defined will be false. Line 71 is false because there is no ':' in pDim Line 89 is false because SCAN( '', pDim ) = 1 This leads to line 140 being false, and line 193 being true. In the line 193 IF block, pHier has not been redefined to anything. Therefore the HierarchyElementDelete and HierarchyElementInsert statements on line 206 and 207 fail because pHier is still '' Redefining pHier is done in the block following 193, that starts at line 216 # Solution By moving the redefining of pDelim to the beginning, SCAN( '', pDim ) will be 0 instead of 1, which will make line 89 true which will define pHier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix. }bedrock.hier.unwind does nothing (and does not error) under certain parameters
if pDelim = '' and pHier = '' and pDim is one dimension (no delimiter or wildcard characters and does not specify a hierarchy with ':') and pConsol is '*',
then all the places pHier gets defined will be false.
Line 71 is false because there is no ':' in pDim
Line 89 is false because SCAN( '', pDim ) = 1
This leads to line 140 being false, and line 193 being true.
In the line 193 IF block, pHier has not been redefined to anything. Therefore the HierarchyElementDelete and HierarchyElementInsert statements on line 206 and 207 fail because pHier is still ''
Redefining pHier is done in the block following 193, that starts at line 216
Solution
By moving the redefining of pDelim to the beginning, SCAN( '', pDim ) will be 0 instead of 1, which will make line 89 true which will define pHier.