Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Refactoring #5

Merged
merged 3 commits into from
Jul 9, 2023
Merged

Code Refactoring #5

merged 3 commits into from
Jul 9, 2023

Commits on Jul 9, 2023

  1. Added ascii_common 

    - removed ReadLineResult from ascii_stream and put it in ascii_common, since ReadLineResult is used by both AsciiStreamReader and AsciiStreamReaderAsync
    @cubicle-jockey
    cubicle-jockey committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    3e561b5 View commit details
    Browse the repository at this point in the history

  2. Bumped version to 0.2.0 

    Because removing ReadLineResult from ascii_stream and putting it in ascii_common is potentially a breaking change.
    @cubicle-jockey
    cubicle-jockey committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    651c8de View commit details
    Browse the repository at this point in the history

  3. Updated a comment 

    - clarified that Success(usize) contains the number of bytes pushed to the result buf, not the number of bytes read.
    @cubicle-jockey
    cubicle-jockey committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    cfc0a83 View commit details
    Browse the repository at this point in the history