Repository navigation
ci: run the repository-tooling tests when only agent-evals or a tooling test module changes - #965
Merged
Merged
Conversation
…ng test module changes Add agent-evals/** and the ten repository-tooling test modules missing from the tooling path filter, so repo-tests runs when only they change, and guard that every REPO_TOOLING_MODULES entry selects the tooling lane. Refs #964 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
Registry changes do not trigger the tooling lane, allowing future omissions to bypass the new guard.
1 open finding
What changed in this PR
Closes CI selection gaps for repository-tooling tests while preserving the existing lane split.
Changes:
- Adds agent-evaluation inputs and ten tooling test modules to the tooling filter.
- Adds path-selection cases and a module-completeness guard.
- Updates CI documentation and the changelog.
| File | Description |
|---|---|
| test/test_workflow_path_impact.py | Adds selection cases and completeness guard. |
| docs/llms-full.txt | Refreshes generated CI documentation. |
| docs/ko/CI_POLICY.md | Updates Korean tooling-lane guidance. |
| docs/CI_POLICY.md | Documents expanded tooling triggers. |
| CHANGELOG.md | Records the CI selection fix. |
| .github/workflows/ci.yml | Expands the tooling path filter. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Refs #964 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Maintainer review (delegated) of head 0654640.
Approved for merge. |
This was referenced Oct 16, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What this PR does
Makes the
repo-testsjob run when a pull request changes onlyagent-evals/**or only a repository-tooling test module. It also adds a guard so that a future module cannot fall out of the filter again.Why
repo-marked tests (theREPO_TOOLING_MODULESintest/conftest.py) run only inrepo-tests, because the offline lanes deselect them with-m "not repo".repo-testsstarts only when thetoolingpath filter inci.ymlmatches.On main (ea9a4b7),
test_workflow_path_impact.py's_selected()shows these paths selectingcode(ordocs) but nevertooling:agent-evals/**test/test_agent_eval.pySo a pull request that changed only an agent-evals task or fixture, or only one of those modules, ran those tests nowhere. Lane A found the agent-evals case after #961–#963. The guard found the other nine.
Alternative not chosen
test/**glob. It would send every test change torepo-tests. Listing the modules keeps the lane's selection precise, and the guard keeps the list complete.Changes
.github/workflows/ci.yml: thetoolingfilter now also listsagent-evals/**,test/conftest.py(where the registry lives) and the following modules, with a comment explaining why:test/test_agent_eval.pytest_bench_artifact.pytest_check_docs_translation.pytest_docs_provenance_hook.pytest_docs_reason.pytest_make_integration.pytest_release_detect.pytest_sqlalchemy_range.pytest_support_claims.pytest_verify_dist.pytest/test_workflow_path_impact.py:agent-evals/README.md(docs+tooling), an agent-evals task and fixture, andtest/test_agent_eval.py;test_every_repository_tooling_module_selects_the_tooling_lane, which asserts that everyREPO_TOOLING_MODULESentry selectstooling.docs/CI_POLICY.mdanddocs/ko/CI_POLICY.md: state that tooling includes these paths.docs/llms-full.txtis regenerated.CHANGELOG.md: a### CIentry.Known differences / Not changed
ci.ymlis a protected path, so this needs maintainer review.Validation
pytest -m repo test/test_workflow_path_impact.py→ 48 passed. With the oldci.ymland the new tests, 5 tests fail, the guard among them, which lists the 10 missing modules.pytest -m repo test/→ 1064 passed, 12 skipped.check_docs_links.pylint_changelog.pycheck_docs_translation.pycheck_agents_docs.pycheck_support_claims.pygenerate_llms_full.py→llms-full.txtregenerated.Development route: Claude Code (standalone agent); protected path (
.github/workflows/ci.yml), needs a maintainer review before merge.Refs #964
🤖 Generated with Claude Code